| Conditions | 2 |
| Total Lines | 192 |
| Code Lines | 145 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | import React, { Component } from "react" |
||
| 139 | renderTeamSquadStats = (team) => { |
||
| 140 | if (this.state.loading === false && this.state.data) { |
||
| 141 | const { |
||
| 142 | squadPlayerStatistics = [], |
||
| 143 | } = this.state.data |
||
| 144 | |||
| 145 | squadPlayerStatistics.sort((a, b) => b.minutes - a.minutes) |
||
| 146 | |||
| 147 | return ( |
||
| 148 | <article className={"team__stats__detail card"}> |
||
| 149 | <header className={"card__header"}> |
||
| 150 | <h4>Spelers</h4> |
||
| 151 | </header> |
||
| 152 | <div className={"card__content"}> |
||
| 153 | <table className={"team__stats__table team__stats__table--players"}> |
||
| 154 | <thead> |
||
| 155 | <tr> |
||
| 156 | <th |
||
| 157 | className={ |
||
| 158 | "team__stats__column team__stats__column--string" |
||
| 159 | } |
||
| 160 | > |
||
| 161 | Speler |
||
| 162 | </th> |
||
| 163 | <th |
||
| 164 | className={ |
||
| 165 | "team__stats__column team__stats__column--number" |
||
| 166 | } |
||
| 167 | > |
||
| 168 | <span title="Wedstrijden gespeeld">P</span> |
||
| 169 | </th> |
||
| 170 | <th |
||
| 171 | className={ |
||
| 172 | "team__stats__column team__stats__column--number" |
||
| 173 | } |
||
| 174 | > |
||
| 175 | <span title="Wedstrijden gewonnen">W</span> |
||
| 176 | </th> |
||
| 177 | <th |
||
| 178 | className={ |
||
| 179 | "team__stats__column team__stats__column--number" |
||
| 180 | } |
||
| 181 | > |
||
| 182 | <span title="Wedstrijden gelijkgespeeld">D</span> |
||
| 183 | </th> |
||
| 184 | <th |
||
| 185 | className={ |
||
| 186 | "team__stats__column team__stats__column--number" |
||
| 187 | } |
||
| 188 | > |
||
| 189 | <span title="Wedstrijden verloren">L</span> |
||
| 190 | </th> |
||
| 191 | <th |
||
| 192 | className={ |
||
| 193 | "team__stats__column team__stats__column--number" |
||
| 194 | } |
||
| 195 | > |
||
| 196 | <img |
||
| 197 | src={iconCardYellow} |
||
| 198 | title="Gele kaart" |
||
| 199 | alt="Gele kaart" |
||
| 200 | className="team__stats__header_icon" |
||
| 201 | /> |
||
| 202 | </th> |
||
| 203 | <th |
||
| 204 | className={ |
||
| 205 | "team__stats__column team__stats__column--number" |
||
| 206 | } |
||
| 207 | > |
||
| 208 | <img |
||
| 209 | src={iconCardRed} |
||
| 210 | title="Rode kaart" |
||
| 211 | alt="Rode kaart" |
||
| 212 | className="team__stats__header_icon" |
||
| 213 | /> |
||
| 214 | </th> |
||
| 215 | <th |
||
| 216 | className={ |
||
| 217 | "team__stats__column team__stats__column--number" |
||
| 218 | } |
||
| 219 | > |
||
| 220 | <img |
||
| 221 | src={iconGoal} |
||
| 222 | title="Doelpunt(en) gescoord" |
||
| 223 | alt="Doelpunt(en) gescoord" |
||
| 224 | className="team__stats__header_icon" |
||
| 225 | /> |
||
| 226 | </th> |
||
| 227 | <th |
||
| 228 | className={ |
||
| 229 | "team__stats__column team__stats__column--number" |
||
| 230 | } |
||
| 231 | > |
||
| 232 | <img |
||
| 233 | src={iconCleansheet} |
||
| 234 | title="Cleansheets" |
||
| 235 | alt="Cleansheets" |
||
| 236 | className="team__stats__header_icon" |
||
| 237 | /> |
||
| 238 | </th> |
||
| 239 | <th |
||
| 240 | className={ |
||
| 241 | "team__stats__column team__stats__column--number" |
||
| 242 | } |
||
| 243 | > |
||
| 244 | <span title="Minuten gespeeld"> |
||
| 245 | <Icon icon="fa-clock-o" /> |
||
| 246 | </span> |
||
| 247 | </th> |
||
| 248 | </tr> |
||
| 249 | </thead> |
||
| 250 | <tbody> |
||
| 251 | {squadPlayerStatistics.map(function (player) { |
||
| 252 | return ( |
||
| 253 | <tr> |
||
| 254 | <td |
||
| 255 | className={ |
||
| 256 | "team__stats__column team__stats__column--string" |
||
| 257 | } |
||
| 258 | > |
||
| 259 | {player.firstName} {player.lastName} |
||
| 260 | </td> |
||
| 261 | <td |
||
| 262 | className={ |
||
| 263 | "team__stats__column team__stats__column--number" |
||
| 264 | } |
||
| 265 | > |
||
| 266 | {player.gamesPlayed} |
||
| 267 | </td> |
||
| 268 | <td |
||
| 269 | className={ |
||
| 270 | "team__stats__column team__stats__column--number" |
||
| 271 | } |
||
| 272 | > |
||
| 273 | {player.gamesWon} |
||
| 274 | </td> |
||
| 275 | <td |
||
| 276 | className={ |
||
| 277 | "team__stats__column team__stats__column--number" |
||
| 278 | } |
||
| 279 | > |
||
| 280 | {player.gamesEqual} |
||
| 281 | </td> |
||
| 282 | <td |
||
| 283 | className={ |
||
| 284 | "team__stats__column team__stats__column--number" |
||
| 285 | } |
||
| 286 | > |
||
| 287 | {player.gamesLost} |
||
| 288 | </td> |
||
| 289 | <td |
||
| 290 | className={ |
||
| 291 | "team__stats__column team__stats__column--number" |
||
| 292 | } |
||
| 293 | > |
||
| 294 | {player.yellowCards} |
||
| 295 | </td> |
||
| 296 | <td |
||
| 297 | className={ |
||
| 298 | "team__stats__column team__stats__column--number" |
||
| 299 | } |
||
| 300 | > |
||
| 301 | {player.redCards} |
||
| 302 | </td> |
||
| 303 | <td |
||
| 304 | className={ |
||
| 305 | "team__stats__column team__stats__column--number" |
||
| 306 | } |
||
| 307 | > |
||
| 308 | {player.goals} |
||
| 309 | </td> |
||
| 310 | <td |
||
| 311 | className={ |
||
| 312 | "team__stats__column team__stats__column--number" |
||
| 313 | } |
||
| 314 | > |
||
| 315 | {player.cleanSheets} |
||
| 316 | </td> |
||
| 317 | <td |
||
| 318 | className={ |
||
| 319 | "team__stats__column team__stats__column--number" |
||
| 320 | } |
||
| 321 | > |
||
| 322 | {player.minutes || "0"}' |
||
| 323 | </td> |
||
| 324 | </tr> |
||
| 325 | ) |
||
| 326 | })} |
||
| 327 | </tbody> |
||
| 328 | </table> |
||
| 329 | </div> |
||
| 330 | </article> |
||
| 331 | ) |
||
| 367 |